ndimiduk commented on a change in pull request #1179: HBASE-23861. Reconcile 
Hadoop version.
URL: https://github.com/apache/hbase/pull/1179#discussion_r384168804
 
 

 ##########
 File path: hbase-server/pom.xml
 ##########
 @@ -723,9 +723,6 @@
         <dependency>
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-distcp</artifactId>
-          <!--This dependency is not in top-level pom so needs
-               version specified-->
 
 Review comment:
   Looking at the `hadoop-2.0` profile in `hbase-server/pom.xml`, I see there's 
a version specified there for the `hadoop-distcp` dependency. You can apply the 
same change to this profile that you did to the `hadoop-3.0` profile, so that 
it will resolve the version from the parent pom's profile instead of the 
hard-coded version.
   
   
https://github.com/ndimiduk/hbase/blob/00fc46756abb99de6f833997499505f89c9752e8/hbase-server/pom.xml#L612-L618

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to