busbey commented on a change in pull request #1203: HBASE-23878 : Backport
HBASE-22040 to branch-2.1
URL: https://github.com/apache/hbase/pull/1203#discussion_r384567084
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1185,41 +1184,41 @@ private void checkAndGetTableName(byte[]
encodeRegionName, AtomicReference<Table
}
@Override
- public CompletableFuture<Void> mergeRegions(byte[] nameOfRegionA, byte[]
nameOfRegionB,
- boolean forcible) {
+ public CompletableFuture<Void> mergeRegions(List<byte[]>
nameOfRegionsToMerge, boolean forcible) {
+ if (nameOfRegionsToMerge.size() < 2) {
Review comment:
just to confirm my understanding, we're doing this ourselves instead of
using Preconditions because guava doesn't have a version of Preconditions that
will return a future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
