HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385989825
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
##########
@@ -184,14 +186,16 @@ public void testFlushAndCompactionWithoutTags() throws
Exception {
byte[] row2 = Bytes.toBytes("rowc");
- HTableDescriptor desc = new HTableDescriptor(tableName);
- HColumnDescriptor colDesc = new HColumnDescriptor(fam);
- colDesc.setBlockCacheEnabled(true);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+ new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+ familyDescriptor.setBlockCacheEnabled(true);
// colDesc.setDataBlockEncoding(DataBlockEncoding.NONE);
Review comment:
Also remove the commented out lines when already on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
