anoopsjohn commented on a change in pull request #1219: HBASE-23788 
ROW_INDEX_V1 encoder should consider the secondary index size with the encoded 
data size tracking
URL: https://github.com/apache/hbase/pull/1219#discussion_r386206919
 
 

 ##########
 File path: 
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
 ##########
 @@ -50,9 +50,8 @@ void startBlockEncoding(HFileBlockEncodingContext 
encodingCtx, DataOutputStream
 
   /**
    * Encodes a KeyValue.
-   * @return unencoded kv size written
 
 Review comment:
   In the Javadoc pls add a line which clearly says the need to call the 
EncodingState#postEncode() after the encoding step

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to