ndimiduk commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit 
test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594046942
 
 
   Alright @busbey @saintstack @Apache9 @jatsakthi this change is ready for 
review once more. I'll squish everything together before merge. The changes 
include:
   1. rebuild the `Dockerfile` with support multiple JDK versions, with the two 
supported versions being JDK8 and JDK11, both from the AdoptOpenJDK project. 
(also more pedantic about the versions of the tools we install.)
   1. Rebuild the Jenkinsfile into a multi-stage, parallel workflow. This (1) 
allows us to run the various batteries of tests in parallel and (2) lets us 
side-step a bug in yetus reporting of multijdk results.
   1. Move the inline yetus invocation from the Jenkinsfile into a separate 
script. This supports re-use across the stages.
   
   As you may note in the build-bot spam on this PR, with the move to multiple 
invocations of Yetus, we now get multiple post-backs onto the PR. As future 
work, I'd like to see these comments be replaced by use of the [Checks 
API](https://developer.github.com/v3/checks/). Maybe we could hack something up 
around each invocation of test-patch, but a better experience will require 
native [support from Yetus](https://issues.apache.org/jira/browse/YETUS-952).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to