Jimmy Xiang commented on HBASE-5620:

@Stack, not every invocation will throw an exception.  In case it throws an 
exception, it should be a ServiceException for pb.  It used to be IOException.  
Without the change, for pb calls, it won't get a ServiceException in case 
something goes wrong.  It gets an undeclared exception
with the cause to be an IOE, and the upper layer doesn't know how to handle it.

The Set in Invocation is used to decide if a protocol a pb one, so 
ServiceException should be used.  I put it there because it is
used for both WritableRpcEngine and SecureRpcEngine.

> Convert the client protocol of HRegionInterface to PB
> -----------------------------------------------------
>                 Key: HBASE-5620
>                 URL: https://issues.apache.org/jira/browse/HBASE-5620
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>         Attachments: hbase-5620-sec.patch, hbase-5620_v3.patch, 
> hbase-5620_v4.patch, hbase-5620_v4.patch

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to