pankaj72981 commented on a change in pull request #1223: HBASE-23739
BoundedRecoveredHFilesOutputSink should read the table de…
URL: https://github.com/apache/hbase/pull/1223#discussion_r387445203
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -114,20 +118,24 @@
@VisibleForTesting
WALSplitter(final WALFactory factory, Configuration conf, Path walDir,
FileSystem walFS,
- LastSequenceId idChecker, SplitLogWorkerCoordination
splitLogWorkerCoordination) {
+ Path rootDir, FileSystem rootFS, LastSequenceId idChecker,
+ SplitLogWorkerCoordination splitLogWorkerCoordination) {
this.conf = HBaseConfiguration.create(conf);
String codecClassName =
conf.get(WALCellCodec.WAL_CELL_CODEC_CLASS_KEY,
WALCellCodec.class.getName());
this.conf.set(HConstants.RPC_CODEC_CONF_KEY, codecClassName);
this.walDir = walDir;
this.walFS = walFS;
+ this.rootDir = rootDir;
+ this.rootFS = rootFS;
this.sequenceIdChecker = idChecker;
this.splitLogWorkerCoordination = splitLogWorkerCoordination;
this.walFactory = factory;
PipelineController controller = new PipelineController();
this.tmpDirName =
conf.get(HConstants.TEMPORARY_FS_DIRECTORY_KEY,
HConstants.DEFAULT_TEMPORARY_HDFS_DIRECTORY);
+ this.tableDescriptors = new FSTableDescriptors(rootFS, rootDir, true,
true);
Review comment:
We should reuse the RegionServer FSTableDescriptors instead of creating
FSTableDescriptors instance for each WAL split.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
