jojochuang commented on a change in pull request #15: HBASE-19256. 
[hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389785069
 
 

 ##########
 File path: hbase-shaded-miscellaneous/pom.xml
 ##########
 @@ -89,6 +89,38 @@
                   <pattern>org.apache.commons</pattern>
                   
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
                 </relocation>
+                <relocation>
+                  <pattern>org.eclipse.jetty</pattern>
+                  
<shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>javax</pattern>
 
 Review comment:
   sure no worries. This work is only meant make the community understand the 
scope of change, and whether or not we should do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to