Apache9 commented on a change in pull request #1266: HBASE-23956 Use less
resources running tests
URL: https://github.com/apache/hbase/pull/1266#discussion_r390679841
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
##########
@@ -31,10 +30,16 @@
*/
@InterfaceAudience.Private
class DefaultNettyEventLoopConfig {
Review comment:
Or let's just remove this class. Move the creation of event loop into the
NettyRpcClientConfigHelper directly and honor the hbase.netty.worker.count
configuration when creating? Though a bit strange is that the Configuration
passed in may change but at least it can avoid reading the configuration from
system property...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
