saintstack commented on a change in pull request #1265: HBASE-23077 move
entirely to spotbugs
URL: https://github.com/apache/hbase/pull/1265#discussion_r391367898
##########
File path: dev-support/hbase-personality.sh
##########
@@ -184,18 +184,30 @@ function personality_modules
done
fi
- if [[ ${testtype} == findbugs ]]; then
- # Run findbugs on each module individually to diff pre-patch and
post-patch results and
+ if [[ ${testtype} == spotbugs ]]; then
+ # Run spotbugs on each module individually to diff pre-patch and
post-patch results and
# report new warnings for changed modules only.
- # For some reason, findbugs on root is not working, but running on
individual modules is
+ # For some reason, spotbugs on root is not working, but running on
individual modules is
# working. For time being, let it run on original list of CHANGED_MODULES.
HBASE-19491
for module in "${CHANGED_MODULES[@]}"; do
- # skip findbugs on hbase-shell and hbase-it. hbase-it has nothing
- # in src/main/java where findbugs goes to look
+ # skip spotbugs on hbase-shell and hbase-it. hbase-it has nothing
+ # in src/main/java where spotbugs goes to look
+ # skip hbase-shaded* as there is no java code in them
+ # skip all modules with no java code or at least, non test java code
if [[ ${module} == hbase-shell ]]; then
continue
elif [[ ${module} == hbase-it ]]; then
continue
+ elif [[ ${module} == hbase-shaded* ]]; then
Review comment:
Good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
