infraio commented on a change in pull request #1279: HBASE-23949 refactor
loadBalancer implements for rsgroup balance by t…
URL: https://github.com/apache/hbase/pull/1279#discussion_r391648185
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -360,10 +356,9 @@ protected boolean needsBalance(Cluster cluster) {
}
@Override
- public synchronized List<RegionPlan> balanceCluster(TableName tableName,
Map<ServerName,
- List<RegionInfo>> clusterState) {
- this.tableName = tableName;
- return balanceCluster(clusterState);
+ public synchronized List<RegionPlan> balanceCluster(Map<TableName,
Map<ServerName,
+ List<RegionInfo>>> clusterLoadPerTable) {
+ return super.balanceCluster(clusterLoadPerTable);
Review comment:
If call super method directly, no need to add this method here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
