[ 
https://issues.apache.org/jira/browse/HBASE-23814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058281#comment-17058281
 ] 

Nick Dimiduk commented on HBASE-23814:
--------------------------------------

I've got a local failure of {{TestLogCleaner}},

{noformat}
java.lang.AssertionError: expected:<2> but was:<1>                              
                     
        at 
org.apache.hadoop.hbase.master.cleaner.TestLogsCleaner.testOnConfigurationChange(TestLogsCleaner.java:310)
{noformat}

{noformat}
2020-03-12 21:22:17,896 INFO  [Time-limited test] hbase.ResourceChecker(179): 
after: 
master.cleaner.TestLogsCleaner#testZooKeeperAbortDuringGetListOfReplicators 
Thread=88 (was \
87)                                                                             
                                                                                
                                          
Potentially hanging thread: Time-limited test-SendThread(localhost:65205)       
                                                                                
                                          
        [email protected]/java.lang.Thread.sleep(Native Method)                  
                                                                                
                                          
        
app//org.apache.zookeeper.ClientCnxnSocketNIO.cleanup(ClientCnxnSocketNIO.java:230)
                                                                                
                               
        
app//org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1246)   
                                                                                
                                  
        
app//org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1182)       
                                                                                
                                  
 - Thread LEAK? -, OpenFileDescriptor=267 (was 262) - OpenFileDescriptor LEAK? 
-, MaxFileDescriptor=1048576 (was 1048576), SystemLoadAverage=586 (was 586), 
ProcessCount=155 (was 155), AvailableMemoryMB\
=8645 (was 8661)                                                                
                                                                                
                                          
2020-03-12 21:22:17,905 INFO  [Time-limited test] hbase.ResourceChecker(151): 
before: master.cleaner.TestLogsCleaner#testOnConfigurationChange Thread=88, 
OpenFileDescriptor=267, MaxFileDescriptor=10485\
76, SystemLoadAverage=586, ProcessCount=155, AvailableMemoryMB=8645             
                                                                                
                                          
2020-03-12 21:22:17,917 INFO  [Time-limited test] cleaner.CleanerChore(157): 
Initialize cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner  
                                             
2020-03-12 21:22:17,918 INFO  [Time-limited test] cleaner.CleanerChore(157): 
Initialize 
cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner    
                                  
2020-03-12 21:22:17,918 INFO  [Time-limited test] cleaner.LogCleaner(150): 
Creating 1 old WALs cleaner threads
{noformat}

> Add null checks and logging to misc set of tests
> ------------------------------------------------
>
>                 Key: HBASE-23814
>                 URL: https://issues.apache.org/jira/browse/HBASE-23814
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Trivial
>             Fix For: 3.0.0, 2.3.0
>
>
> I've been studying unit tests of late. A few are failing but then the output 
> is missing a detail or shutdown complains of NPE because startup didn't 
> succeed.
> Here are super minor items I've been carrying around that I'd like to land. 
> They do  not change the function of tests (there is an attempt at a fix of 
> TestLogsCleaner).
> * TestFullLogReconstruction log the server we've chosen to expire and then 
> note where we starting counting rows
> * TestAsyncTableScanException use a define for row counts; count 100 instead 
> of 1000 and see if helps
> * TestRawAsyncTableLimitedScanWithFilter check connection was made before 
> closing it in tearDown
> * TestLogsCleaner use single mod time. Make it for sure less than now in case 
> test runs all in the same millisecond (would cause test fail)
> * TestReplicationBase test table is non-null before closing in tearDown



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to