[
https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058546#comment-17058546
]
Duo Zhang commented on HBASE-23561:
-----------------------------------
I think the patch here introduced a spotbugs warning?
{noformat}
Bug type RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED (click for details)
In class org.apache.hadoop.hbase.master.assignment.RegionStates
In method
org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
Called method java.util.concurrent.ConcurrentSkipListMap.putIfAbsent(Object,
Object)
Type org.apache.hadoop.hbase.master.assignment.RegionStateNode
Value loaded from node
At RegionStates.java:[line 133]
{noformat}
PTAL [~minwoo.kang] and [~stack]
> Look up of Region in Master by encoded region name is O(n)
> ----------------------------------------------------------
>
> Key: HBASE-23561
> URL: https://issues.apache.org/jira/browse/HBASE-23561
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Michael Stack
> Assignee: Minwoo Kang
> Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ public RegionState getRegionState(final String encodedRegionName) {
> // TODO: Need a map <encodedName, ...> but it is just dispatch merge...
> for (RegionStateNode node: regionsMap.values()) {
> if (node.getRegionInfo().getEncodedName().equals(encodedRegionName)) {
> return node.toRegionState();
> }
> }
> return null;
> }}}
> It is not used much so making it trivial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
