ndimiduk commented on a change in pull request #1302: HBASE-23999 [flakey test]
TestTableOutputFormatConnectionExhaust
URL: https://github.com/apache/hbase/pull/1302#discussion_r394046422
##########
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionTool.java
##########
@@ -60,12 +57,6 @@
public void setUp() throws Exception {
this.testUtil.startMiniCluster();
testUtil.createTable(tableName, HBaseTestingUtility.fam1);
- String defaultFS =
testUtil.getMiniHBaseCluster().getConfiguration().get("fs.defaultFS");
- Configuration config = HBaseConfiguration.create();
- config.set("fs.defaultFS", defaultFS);
- String configPath = this.getClass().getClassLoader()
- .getResource("hbase-site.xml").getFile();
- config.writeXml(new FileOutputStream(new File(configPath)));
Review comment:
@wchevreuil can you comment as to why this test needed to write out it's
`hbase-site.xml`? Presumably it was done for a reason and it's not enough to
simply not write it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
