ndimiduk commented on a change in pull request #1305: HBASE-23984 [Flakey
Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1305#discussion_r394653235
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1010,7 +1011,7 @@ public void run() {
} else if (!this.stopping) {
this.stopping = true;
LOG.info("Closing user regions");
- closeUserRegions(this.abortRequested);
+ closeUserRegions(isAborted());
Review comment:
On using a public accessor vs. the private field directly, I am generally
ambivalent. However, this is probably an improvement because it makes the
master dependent on an interface instead of an implementation detail. +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
