Apache9 commented on a change in pull request #1305: HBASE-23984 [Flakey Tests]
TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1305#discussion_r395101717
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
##########
@@ -38,9 +36,13 @@
/**
* Handles closing of a region on a region server.
* <p/>
- * Now for regular close region request, we will use {@link
UnassignRegionHandler} instead. But when
- * shutting down the region server, will also close regions and the related
methods still use this
- * class so we keep it here.
+ * In normal operation, we use {@link UnassignRegionHandler} closing Regions
but when shutting down
+ * the region server and closing out Regions, we use this handler instead; it
does not expect to
Review comment:
The work is done by me before. What I could say is that, we have done a lot
of hacks only for testing, in CloseRegionHandler, just like we want to do in
this patch...
That's why I introduced a new class called UnassignRegionHandler for
implementing the region assignment, and still kept the class here. The first
idea was to just remove this class but I finally gave up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
