ndimiduk commented on a change in pull request #1310: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas… URL: https://github.com/apache/hbase/pull/1310#discussion_r395903858
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/AbstractTestUpdateConfiguration.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.nio.file.StandardCopyOption; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import org.apache.hadoop.hbase.HBaseTestingUtility; +import org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread; + +/** + * Base class to test Configuration Update logic. + */ +public abstract class AbstractTestUpdateConfiguration { + private static final int SERVER_CONFIG_INDEX = 0; Review comment: Why track indices when you could just have three variables like ```java private static final String SERVER_CONFIG = "hbase-site.xml"; private static final String OVERWRITE_SERVER_CONFIG = "hbase-site2.xml"; ... ``` This is what I meant in my earlier comment about descriptive variable names. And for easier debugging, why call the file names 1, 2, 3 -- they can be named whatever we want since we're manually adding them as resources. Might as well make the file names descriptive too, so someone doing forensics later can have a clue. Something like "copy-of-hbase-site.xml", "overrides-for-test-hbase-site.xml", &c. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
