Apache9 commented on a change in pull request #1322: HBASE-24033 Add ut for
loading the corrupt recovered hfiles
URL: https://github.com/apache/hbase/pull/1322#discussion_r396084038
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitUtil.java
##########
@@ -345,16 +345,16 @@ public boolean accept(Path p) {
/**
* Move aside a bad edits file.
- * @param walFS WAL FileSystem used to rename bad edits file.
+ * @param fs the file system used to rename bad edits file.
* @param edits Edits file to move aside.
* @return The name of the moved aside file.
* @throws IOException
*/
- public static Path moveAsideBadEditsFile(final FileSystem walFS, final Path
edits)
+ public static Path moveAsideBadEditsFile(final FileSystem fs, final Path
edits)
Review comment:
Why this name changing? Because for HFile based split we will write HFile to
the root fs instead of wal fs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
