saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r396671715
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -317,7 +318,14 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
do {
hasMore = scanner.next(cells, scannerContext);
- now = EnvironmentEdgeManager.currentTime();
+ currentTime = EnvironmentEdgeManager.currentTime();
+ if (LOG.isDebugEnabled()) {
+ now = currentTime;
+ }
+ if (closeChecker.isClosedByTimeLimit(store, currentTime)) {
Review comment:
s/isClosedByTimeLime/isTimeLimit/ ... and s/isClosedBySizeLiimt/isSizeLimit/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
