[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068112#comment-17068112
]
Josh Elser commented on HBASE-23881:
------------------------------------
Pushed this to master as that branch looks good. A bunch of spin-outs to come
from this... Thinking through them.
* Need backports of the Netty impl to the other 2.x branches which contain
HBASE-23347
* Need to make the same fix to the NIO impl to branches which contain
HBASE-23347
* Need to fix existing tests on those 2.x branches which likely fail due to
the new master registry logic
* Need to expand tests to cover async and sync connection impls on relevant
2.x branches
Theoretically, our code is "wrong" on all branches, but it will only exhibit
this error on branches where we have HBASE-23347. I don't think it's worth it
to proactively fix something we can't actually test/exercise.
> TestShadeSaslAuthenticationProvider failures
> --------------------------------------------
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Bharath Vissapragada
> Assignee: Josh Elser
> Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected<org.apache.hadoop.hbase.DoNotRetryIOException> but
> was<java.io.IOException>
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
