ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604735186 > Is it just me or has the spotbugs disappeared from the build report? That's what I'm trying to enable here. I think the functionality was dropped in HBASE-23077 or HBASE-23767. > The way I read https://issues.apache.org/jira/browse/YETUS-749 ... Ah thanks, I hadn't read the Yetus side of the feature change. I believe that when `SPOTBUGS_HOME` is defined, as we do in our Dockerfile, `-findbugs` is not necessary since t that's the default mode. I'm currently thinking there's a plugin dependency for spotbugs that I'm missing because of the explicit omission of `all` in the JDK-specific plugin lists. But I cannot find it. On this PR, for JDK8, I specify `--plugins=compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit,spotbugs`. When I run yetus locally using an even reduced list, `--plugins=compile,javac,javadoc,mav en,mvninstall,spotbugs`, I get the SpotBugs check as expected.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
