saintstack commented on a change in pull request #1401: HBASE-24075: Fix a race
between master shutdown and metrics (re)init
URL: https://github.com/apache/hbase/pull/1401#discussion_r401357417
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##########
@@ -130,9 +134,12 @@ private void waitForFetchToFinish() throws
InterruptedException {
* trying get from a clean cache.
*
* @return ClusterId by reading from FileSystem or null in any error case or
cluster ID does
- * not exist on the file system.
+ * not exist on the file system or if the server initiated a tear down.
*/
public String getFromCacheOrFetch() {
+ if (server.isStopping() || server.isStopped()) {
Review comment:
Great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
