ndimiduk commented on a change in pull request #1408: HBASE-24086 Disable
output stream capability enforcement when running in standalone mode
URL: https://github.com/apache/hbase/pull/1408#discussion_r401930132
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -350,11 +350,18 @@ public static void setWALRootDir(final Configuration c,
final Path root) {
public static FileSystem getWALFileSystem(final Configuration c) throws
IOException {
Path p = getWALRootDir(c);
FileSystem fs = p.getFileSystem(c);
- // hadoop-core does fs caching, so need to propogate this if set
+ // hadoop-core does fs caching, so need to propagate this if set
String enforceStreamCapability = c.get(UNSAFE_STREAM_CAPABILITY_ENFORCE);
if (enforceStreamCapability != null) {
fs.getConf().set(UNSAFE_STREAM_CAPABILITY_ENFORCE,
enforceStreamCapability);
}
+ if (!c.getBoolean(HConstants.CLUSTER_DISTRIBUTED, false)) {
Review comment:
> make it an else if? meaning if the user didn't override
UNSAFE_STREAM_CAPABILITY_ENFORCE and its a local fs mode..
I explicitly disable it here because we know it doesn't work with the local
filesystem. There are plenty of places where conf lookups of
`UNSAFE_STREAM_CAPABILITY_ENFORCE` have a default of `true`, so leaving it
unset sometimes doesn't help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
