Reidddddd commented on a change in pull request #1435: HBASE-24112 [RSGroup]
Support renaming rsgroup
URL: https://github.com/apache/hbase/pull/1435#discussion_r403812183
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -4146,4 +4148,21 @@ private void getProcedureResult(long procId,
CompletableFuture<Void> future, int
resp -> resp.hasRSGroupInfo() ?
ProtobufUtil.toGroupInfo(resp.getRSGroupInfo()) : null)))
.call();
}
+
+ @Override
+ public CompletableFuture<Void> renameRSGroup(String oldName, String newName)
{
Review comment:
I think it is ok to leave it as it is, server side will throw
ConstraintException if both are empty. Other methods like addRSGroup neither
checks non-empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
