bharathv commented on a change in pull request #1439: HBASE-24121
[Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it
should be
URL: https://github.com/apache/hbase/pull/1439#discussion_r404246867
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -313,6 +314,7 @@ public void onConfigurationChange(Configuration newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver) scheduler).onConfigurationChange(newConf);
}
+ HBasePolicyProvider.init(newConf, authManager);
Review comment:
Regarding thread-safety, do we need to synchronize on authManager while this
happens? Otherwise authorize() requests and this init can race and can result
in some weird authz results..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
