virajjasani commented on a change in pull request #1455: HBASE-24138 log more
details about balancer decisions for StochasticLoadBalancer
URL: https://github.com/apache/hbase/pull/1455#discussion_r405720235
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -331,28 +331,29 @@ protected boolean needsBalance(TableName tableName,
Cluster cluster) {
for (CostFunction c : costFunctions) {
float multiplier = c.getMultiplier();
if (multiplier <= 0) {
+ LOG.trace("{} not needed because multiplier is <= 0",
c.getClass().getSimpleName());
continue;
}
if (!c.isNeeded()) {
- LOG.debug("{} not needed", c.getClass().getSimpleName());
+ LOG.trace("{} not needed", c.getClass().getSimpleName());
continue;
}
sumMultiplier += multiplier;
total += c.cost() * multiplier;
}
- if (total <= 0 || sumMultiplier <= 0
- || (sumMultiplier > 0 && (total / sumMultiplier) <
minCostNeedBalance)) {
+ boolean balanced = total <= 0 || sumMultiplier <= 0 ||
+ (sumMultiplier > 0 && (total / sumMultiplier) < minCostNeedBalance);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("{} {}; total cost={}, sum multiplier={}; cost/multiplier to
need a balance is {}",
+ balanced ? "Skipping load balancing because balanced" : "We need to
load balance",
+ isByTable ? String.format("table (%s)", tableName) : "cluster",
+ total, sumMultiplier, minCostNeedBalance);
Review comment:
We want to close the bracket of `if (LOG.isDebugEnabled()) {` here right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
