busbey commented on a change in pull request #1450: HBASE-24126 Up the
container nproc uplimit from 10000 to 12500
URL: https://github.com/apache/hbase/pull/1450#discussion_r405730607
##########
File path: dev-support/hbase-personality.sh
##########
@@ -513,6 +516,7 @@ function hadoopcheck_parse_args
## @stability evolving
function hadoopcheck_docker_support
{
+ DOCKER_EXTRAARGS=("${DOCKER_EXTRAARGS[@]}" "--ulimit" "nproc=12500")
Review comment:
the reference you've added here is in the function that defines what is
needed when we run docker specifically _just_ when we're doing the hadoopcheck
test.
if we need it all the time, then it should be elsewhere. It looks it should
be coming in from the YETUS_ARGS that have been added to the wrapper. If that's
the case, then removing it here should have no impact on what happens. If
removing it here makes it so things don't do what you expect, then something
else is broken because the inclusion here is only going to happen when the
hadoopcheck test is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
