francisjjf commented on a change in pull request #1453: HBASE-24132 Upgrade to
Apache ZooKeeper 3.5.7
URL: https://github.com/apache/hbase/pull/1453#discussion_r406643760
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
##########
@@ -113,6 +113,9 @@ public void test() throws Exception {
cluster.killRegionServer(rs2.getServerName());
UTIL.waitFor(30_000, () -> rs2.isStopped() && !rs2.isAlive());
UTIL.waitFor(30_000, () -> rs1.isStopped() && !rs1.isAlive());
+ // make sure none of regionserver threads is alive.
+ UTIL.waitFor(30_000, () ->
+ UTIL.getMiniHBaseCluster().getLiveRegionServerThreads().isEmpty());
// Start up everything again
Review comment:
add a rs all down check here to make the testcase stable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
