BukrosSzabolcs commented on a change in pull request #1512: HBASE-24186:
RegionMover ignores replicationId
URL: https://github.com/apache/hbase/pull/1512#discussion_r408998232
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
##########
@@ -755,7 +755,8 @@ private ServerName getServerNameForRegion(RegionInfo
region) throws IOException
return null;
}
HRegionLocation loc =
-
conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(),
true);
+
conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(),
Review comment:
I realized my original description of the issue is not correct. This does
not prevent the moving of the region, the result of getServerNameForRegion() is
only used in the validation of the move, so it only forces the move to try to
repeat itself because it does not realize the move already happened. So it just
slows down the process but not break it.
I tried to write a test for this, but the only thing I could come up with is
a test that goes trough regions on a rs and checks if getServerNameForRegion
founds the correct server for it. I can add it if you insist but I see very
little added value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
