saintstack commented on a change in pull request #1485: HBASE-23969 Meta
browser should show all `info` columns
URL: https://github.com/apache/hbase/pull/1485#discussion_r409160973
##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -387,68 +388,91 @@ if (fqtn != null && master.isInitialized()) {
}
}
%>
-<table class="table table-striped">
- <tr>
- <th>RegionName</th>
- <th>Start Key</th>
- <th>End Key</th>
- <th>Replica ID</th>
- <th>RegionState</th>
- <th>ServerName</th>
- </tr>
-<%
- final boolean metaScanHasMore;
- byte[] lastRow = null;
- try (final MetaBrowser.Results results = metaBrowser.getResults()) {
- for (final RegionReplicaInfo regionReplicaInfo : results) {
- lastRow = Optional.ofNullable(regionReplicaInfo)
- .map(RegionReplicaInfo::getRow)
- .orElse(null);
- if (regionReplicaInfo == null) {
-%>
- <tr>
- <td colspan="6">Null result</td>
- </tr>
-<%
- continue;
- }
+<div style="overflow-x: auto">
+ <table class="table table-striped nowrap">
+ <tr>
+ <th>RegionName</th>
+ <th>Start Key</th>
+ <th>End Key</th>
+ <th>Replica ID</th>
+ <th>RegionState</th>
+ <th>ServerName</th>
+ <th>Sequence Number</th>
+ <th>Target ServerName</th>
+ <th>Merge RegionNames</th>
+ <th>SplitA</th>
+ <th>SplitB</th>
Review comment:
How we do merge? Merge names can be more merge001, merge002... we print them
all out in Merge RegionNames? If so, why split different?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
