joshelser commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r409883440
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+ if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+ }
+ List<Method> methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
Review comment:
We see this pretty often, actually. Folks will remain on a release line,
either upstream releases or downstream re-packagings of those releases.
It would definitely be an improvement to get the discrete list of things
that the server supports rather than guessing based on a version string. Like
you say, that makes for good follow-on work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
