Reidddddd commented on a change in pull request #1494: HBASE-24174 Fix findbugs
warning in branch-1
URL: https://github.com/apache/hbase/pull/1494#discussion_r410000670
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -2265,14 +2264,9 @@ public void onConfigurationChange(Configuration
newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver)scheduler).onConfigurationChange(newConf);
}
- // Make sure authManager will read hbase-policy file
- System.setProperty("hadoop.policy.file", "hbase-policy.xml");
- synchronized (authManager) {
- authManager.refresh(newConf, new HBasePolicyProvider());
+ if (authorize) {
Review comment:
Yes, it is, to avoid unnecessary refresh. If authorization is disabled, then
no need to refresh it which it is time consuming.
We should forward-port this patch to branch-2+ and master as well, quite
some changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
