[ 
https://issues.apache.org/jira/browse/HBASE-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258803#comment-13258803
 ] 

nkeywal commented on HBASE-5844:
--------------------------------

For the tracker, it's my private workaround for HBASE-5666, it should not have 
been included in this patch. Sorry about this.

I think it's better to delete the file explicitly, just after the znode 
deletion. HRegionServer#deleteMyEphemeralNode is called only once, and I added 
deleteMyEphemeralNodeOnDisk just after this call. If we rely on #deleteOnExit, 
I fear we could have the file deleted with a still alive znode. I'm not sure 
and I have not tried it, but I think it's too easy to enter into the 
jvm-specific-behavior space here.

I will fix the java code and try the whole fix on a real cluster for the v2.

Thanks you for the review.




                
> Delete the region servers znode after a regions server crash
> ------------------------------------------------------------
>
>                 Key: HBASE-5844
>                 URL: https://issues.apache.org/jira/browse/HBASE-5844
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver, scripts
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>         Attachments: 5844.v1.patch
>
>
> today, if the regions server crashes, its znode is not deleted in ZooKeeper. 
> So the recovery process will stop only after a timeout, usually 30s.
> By deleting the znode in start script, we remove this delay and the recovery 
> starts immediately.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to