Reidddddd commented on a change in pull request #1537: HBASE-24174 Fix findbugs
warning on ServiceAuthorizationManager for master branch
URL: https://github.com/apache/hbase/pull/1537#discussion_r410034171
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -597,7 +592,7 @@ public void addCallSize(final long diff) {
* @param addr InetAddress of incoming connection
* @throws AuthorizationException when the client isn't authorized to talk
the protocol
*/
- public void authorize(UserGroupInformation user, ConnectionHeader connection,
+ public synchronized void authorize(UserGroupInformation user,
ConnectionHeader connection,
Review comment:
Oh yes, should do. Will fix in next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
