virajjasani commented on a change in pull request #1509: HBASE-24182 log when 
the region is set to closing status
URL: https://github.com/apache/hbase/pull/1509#discussion_r410204833
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 ##########
 @@ -1655,6 +1655,7 @@ public void setTimeoutForWriteLock(long 
timeoutForWriteLock) {
       }
     }
     this.closing.set(true);
+    LOG.info("Closing {}", this);
 
 Review comment:
   Journal log is at Debug level anyways right? Let this be Info level, should 
be good. Imp point here is of timing of these logs and hence, if we debug from 
logs based on region name, we can see sorting of chronological events one after 
another and that way having this Info log is beneficial (although redundant).
   Let's wait for @apurtell 's final call on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to