saintstack commented on a change in pull request #1540: HBASE-24185: Junit tests do not behave well with System.exit or Runti… URL: https://github.com/apache/hbase/pull/1540#discussion_r410391934
########## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/SystemExitRule.java ########## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase; + +import java.io.FileDescriptor; +import java.net.InetAddress; +import java.security.Permission; +import org.junit.rules.TestRule; +import org.junit.runner.Description; +import org.junit.runners.model.Statement; + +public class SystemExitRule implements TestRule { + + public SystemExitRule() { + + } + + @Override public Statement apply(final Statement s, Description d) { + return new Statement() { + @Override public void evaluate() throws Throwable { + + try { + forbidSystemExitCall(); + s.evaluate(); + } finally { + System.setSecurityManager(null); + } + } + + }; + }; + + // Exiting the JVM is not allowed in tests and this exception is thrown instead + // when it is done + public static class ExitTrappedException extends SecurityException { + } + + private static void forbidSystemExitCall() { + final SecurityManager securityManager = new SecurityManager() { Review comment: Have to create it each time? Can we not just create once and then put it in place before evaluate? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
