arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410716369
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List<NodeAndData> newNodes = new ArrayList<>();
for (String node : nodes) {
+ if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
Review comment:
For branch-1.3.x this is an issue, the reason I have explained in the issue
description.
For master and branch-2, this PR change is for improvement as these branches
do not use zk based region assignment.
Code change is same, for branch-1.3.x it is for the fix for other branches
it is just improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
