Apache9 commented on a change in pull request #1548:
URL: https://github.com/apache/hbase/pull/1548#discussion_r411940906
##########
File path: dev-support/hbase-personality.sh
##########
@@ -146,7 +146,7 @@ function personality_modules
fi
if [[ -n "${HADOOP_PROFILE}" ]]; then
- extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"
+ extra="${extra} -Phadoop-${HADOOP_PROFILE}"
Review comment:
For maven it is hard to add multiple activating conditions so on master
branch, the hadoop-3.0 profile can only be actived without specifying
hadoop.profile. In general, using -Phadoop-3.0 should work on all branches but
seems we have an enforcer rule for checking the property. Let me take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
