virajjasani commented on a change in pull request #1511:
URL: https://github.com/apache/hbase/pull/1511#discussion_r412365908



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -1223,6 +1227,20 @@ protected boolean areSomeRegionReplicasColocated(Cluster 
c) {
     return false;
   }
 
+  protected final synchronized boolean idleRegionExist(Cluster c){

Review comment:
       You have already removed `synchronized` and it's fine to do so, anyways 
method is now in BaseLoadBalancer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to