ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r414469707
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -2898,4 +2915,40 @@ public int getMaxCompactedStoreFileRefCount() {
? maxCompactedStoreFileRefCount.getAsInt() : 0;
}
+ @Override
+ public long getReadRequestsFromStoreCount() {
+ return getRequestsFromStore.sum();
+ }
+
+ @Override
+ public long getGetRequestsCountFromMemstore() {
+ return getRequestsFromMemstore.sum();
+ }
+
+ @Override
+ public long getGetRequestsCountFromFile() {
+ return getRequestsFromFile.sum();
+ }
+
+ void incrGetRequestsFromStore() {
+ getRequestsFromStore.increment();
+ if (metricsStore != null) {
+ metricsStore.updateGet();
+ }
+ }
+
+ void updateMetricsStore(boolean memstoreRead) {
+ if (memstoreRead) {
+ getRequestsFromMemstore.increment();
+ } else {
+ getRequestsFromFile.increment();
+ }
+ if (metricsStore != null) {
+ if (memstoreRead) {
+ metricsStore.updateMemstoreGet();
+ }
+ metricsStore.updateFileGet();
Review comment:
good catch. Thanks for the reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
