bsglz commented on a change in pull request #767:
URL: https://github.com/apache/hbase/pull/767#discussion_r415289682
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
##########
@@ -372,10 +372,11 @@ protected static Cell createStartKeyFromRow(byte[]
startRow, ScanInfo scanInfo)
if (userScan != null) {
if (userScan.isRaw()) {
resultMaxVersion = userScan.getMaxVersions();
+ maxVersionToCheck = userScan.getMaxVersions();
} else {
resultMaxVersion = Math.min(userScan.getMaxVersions(),
scanInfo.getMaxVersions());
+ maxVersionToCheck = userScan.hasFilter() ? scanInfo.getMaxVersions() :
resultMaxVersion;
Review comment:
> Are you sure that we can't use maxVersionToCheck = resultMaxVersion
here?
My understanding is that when use filter,if just check resultMaxVersion, it
maybe lose some cells which version is not exceed the max version of
columnfamily.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
##########
@@ -372,10 +372,11 @@ protected static Cell createStartKeyFromRow(byte[]
startRow, ScanInfo scanInfo)
if (userScan != null) {
if (userScan.isRaw()) {
resultMaxVersion = userScan.getMaxVersions();
+ maxVersionToCheck = userScan.getMaxVersions();
} else {
resultMaxVersion = Math.min(userScan.getMaxVersions(),
scanInfo.getMaxVersions());
+ maxVersionToCheck = userScan.hasFilter() ? scanInfo.getMaxVersions() :
resultMaxVersion;
Review comment:
> Are you sure that we can't use maxVersionToCheck = resultMaxVersion
here?
My understanding is that when use filter,if just check resultMaxVersion, it
maybe lose some cells which version is not exceed the max version of
columnfamily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
