ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415518856
########## File path: hbase-common/src/main/resources/hbase-default.xml ########## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the important. See http://hbase.apache.org/book.html#offheap.blockcache for more information. </description> </property> - <property> - <name>hbase.hstore.compaction.throughput.lower.bound</name> - <value>52428800</value> - <description>The target lower bound on aggregate compaction throughput, in bytes/sec. Allows - you to tune the minimum available compaction throughput when the - PressureAwareCompactionThroughputController throughput controller is active. (It is active by - default.)</description> - </property> - <property> - <name>hbase.hstore.compaction.throughput.higher.bound</name> - <value>104857600</value> - <description>The target upper bound on aggregate compaction throughput, in bytes/sec. Allows - you to control aggregate compaction throughput demand when the - PressureAwareCompactionThroughputController throughput controller is active. (It is active by - default.) The maximum throughput will be tuned between the lower and upper bounds when - compaction pressure is within the range [0.0, 1.0]. If compaction pressure is 1.0 or greater - the higher bound will be ignored until pressure returns to the normal range.</description> - </property> Review comment: Maybe I should create another issue about how to update config in junit tests. In this patch I can use onConfigurationChange to update it ,likes TestCompactionWithThroughputController ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org