wchevreuil commented on a change in pull request #1591:
URL: https://github.com/apache/hbase/pull/1591#discussion_r415667103
##########
File path: hbase-protocol-shaded/src/main/protobuf/rest/ScannerMessage.proto
##########
@@ -28,6 +28,7 @@ message Scanner {
optional int32 maxVersions = 7;
optional string filter = 8;
optional int32 caching = 9; // specifies REST scanner caching
- repeated string labels = 10;
- optional bool cacheBlocks = 11; // server side block caching hint
+ optional int32 limit = 10;
Review comment:
Nit: Avoid renumbering previous existing fields? Not that this would be
a big deal, since this protobuf message is used within REST only, but better to
avoid unnecessary changes in the protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
