mkazia commented on pull request #1565:
URL: https://github.com/apache/hbase/pull/1565#issuecomment-620173939


   @joshelser thanks for looking into this. 
   The code path for creating the SaslClient 
([`NettyHBaseSaslRpcClient`](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java#L74))
 is not wrapped in the doAs. You can see from the stack trace that is given in 
the initial jira. In the Class you mentioned, doAs is wrapped for 
[`saslRpcClient.getInitialResponse()`](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java#L119)
 and 
[`saslRpcClient.evaluateChallenge(challenge)`](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java#L157).
 I have shown from the example/test code, while Oracle/Open JDK does not 
require the **creation of SaslClient** to be wrapped in doAs, IBM JDK requires 
it. And this is all this PR does, wrapping the creation of SaslClient creation 
in doAs.
   
   If this is still not clear or if there is a point you are making that I'm 
not following, please let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to