[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259813#comment-13259813
]
Uma Maheswara Rao G commented on HBASE-5857:
--------------------------------------------
Chinna, if you still retain this testcode in your next patch, please take care
of this comments.
1) {code}
try {
+ regionServer.openRegion(REGIONINFO);
+ } catch (RegionAlreadyInTransitionException e) {
+ fail("It should not throw this exception " + e);
+ }
{code}
you need not catch the exception explicitely. Let the test fail with this
exception.
Javadoc of your test should say about the expectation of your test.
2) {code}
try {
+ regionServer.openRegion(REGIONINFO);
+ fail("It should throw IOException ");
+ } catch (Exception e) {
+ }
{code}
It would great if we catch the IOException, instead of Exception.
3)Also unnecessary empty line in patch.
> RIT map in RS not getting cleared while region opening
> ------------------------------------------------------
>
> Key: HBASE-5857
> URL: https://issues.apache.org/jira/browse/HBASE-5857
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
> HBASE-5857_trunk.patch
>
>
> While opening the region in RS after adding the region to
> regionsInTransitionInRS if tableDescriptors.get() throws exception the region
> wont be cleared from regionsInTransitionInRS. So next time if it tries to
> open the region in the same RS it will throw the
> RegionAlreadyInTransitionException.
> if swap the below statement this issue wont come.
> {code}
> this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
> HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
