[ 
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097651#comment-17097651
 ] 

Michael Stack edited comment on HBASE-24280 at 5/1/20, 8:32 PM:
----------------------------------------------------------------

bq. can we update all the branches to use maven profile activation instead of a 
property?

So, on branch-2, you'd have to specify -Phadoop-2.0 or -Phadoop-3.0? If you 
left off profile, it'd not work?

In branch-2 currently, as per the findings posted above by [~stoty], you have 
to currently do -Dhadoop.profile... if you do -PPROFILE, it is broke.

Is our recipe to be no profile for hadoop on master (or -Phadoop-3.0) but if on 
branch-2, you must use system property; i.e. -Dhadoop.profile=X-X (This is what 
our [~elserj] have over on the nightly hbase-personality 
https://github.com/apache/hbase/pull/1609/files).

Thanks.


was (Author: stack):
bq. can we update all the branches to use maven profile activation instead of a 
property?

So, on branch-2, you'd have to specify -Phadoop-2.0 or -Phadoop-3.0? If you 
left off profile, it'd not work?

> TestSecureRESTServer started failing in nightlies for Hadoop3
> -------------------------------------------------------------
>
>                 Key: HBASE-24280
>                 URL: https://issues.apache.org/jira/browse/HBASE-24280
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 2.3.0
>
>         Attachments: HBASE-24280.master.001.patch, 
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer 
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn 
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0 
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to 
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker 
> container build issues. Will be interesting to see if it fails there. It did 
> not fail the master nightly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to