[
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259935#comment-13259935
]
stack commented on HBASE-5848:
------------------------------
@Ram This is a nit comment for future patches, not for this one.
I would suggest you avoid changes like below going forward:
{code}
- hRegionInfos = new HRegionInfo[]{
- new HRegionInfo(hTableDescriptor.getName(), null, null)};
+ hRegionInfos = new HRegionInfo[] { new HRegionInfo(hTableDescriptor
+ .getName(), null, null) };
{code}
The replacement is harder to read w/ its break in the middle of a phrase.
Patch lgtm.
Lars, does this fix the issue you saw?
> Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to
> abort
> --------------------------------------------------------------------------------
>
> Key: HBASE-5848
> URL: https://issues.apache.org/jira/browse/HBASE-5848
> Project: HBase
> Issue Type: Bug
> Components: client
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Attachments: HBASE-5848.patch
>
>
> A coworker of mine just had this scenario. It does not make sense the
> EMPTY_START_ROW as splitKey (since the region with the empty start key is
> implicit), but it should not cause the HMaster to abort.
> The abort happens because it tries to bulk assign the same region twice and
> then runs into race conditions with ZK.
> The same would (presumably) happen when two identical split keys are passed,
> but the client blocks that. The simplest solution here is to also block
> passed null or EMPTY_START_ROW as split key by the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
