huaxiangsun commented on a change in pull request #1613:
URL: https://github.com/apache/hbase/pull/1613#discussion_r418718311
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##########
@@ -134,7 +135,7 @@ protected synchronized void chore() {
loadRegionsFromInMemoryState();
loadRegionsFromRSReport();
try {
- loadRegionsFromFS();
+ loadRegionsFromFS(scanForMergedParentRegions());
Review comment:
@saintstack Yeah the in-memory state/meta row for merged parents are let
go at early state of MergeRegionsProcedures.
@timoha Per Stack's comments about the source of truth is the in-memory
database (meta/procedure store are ways to recover in-memory databse since they
are persistent).
At this moment, there is no other usage of regions from meta in hbck chore,
the merged parents info is a special case, they are columns from the child
region, the only source of truth for merged parents. We can maintain the
in-memory hashset for merged parent if meta scan is too costly, which can be
addressed later. In case of the future requirements,
scanForMergedParentRegions() can be modified to get more info from meta.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
