wchevreuil commented on a change in pull request #1627:
URL: https://github.com/apache/hbase/pull/1627#discussion_r418984035
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFiles.java
##########
@@ -101,6 +101,7 @@ public static void setUpBeforeClass() throws Exception {
// change default behavior so that tag values are returned with normal rpcs
util.getConfiguration().set(HConstants.RPC_CODEC_CONF_KEY,
KeyValueCodecWithTags.class.getCanonicalName());
+
util.getConfiguration().setBoolean(BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY,
false);
Review comment:
Is this really needed? Isn't BULK_LOAD_HFILES_BY_FAMILY loaded as false
by default if not set on LoadIncrementalHFiles#195? Or perhaps you can move
this for a separate method that could be overridden by
TestLoadIncrementalHFilesByFamily to avoid duplicating whole setUpBeforeClass
in the child class?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java
##########
@@ -141,13 +141,15 @@
public final static String IGNORE_UNMATCHED_CF_CONF_KEY =
BulkLoadHFiles.IGNORE_UNMATCHED_CF_CONF_KEY;
public final static String ALWAYS_COPY_FILES =
BulkLoadHFiles.ALWAYS_COPY_FILES;
+ public final static String BULK_LOAD_HFILES_BY_FAMILY =
BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY;
Review comment:
nit: why not make BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY public, then
remove this variable here?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFilesByFamily.java
##########
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.hadoop.hbase.tool;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.codec.KeyValueCodecWithTags;
+import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+
+public class TestLoadIncrementalHFilesByFamily extends
TestLoadIncrementalHFiles {
Review comment:
Does this test class actually make sense, without testing the specific
new logic added? I mean, even without the group by family feature this test
class will pass, so it's not shielding us from inadvertently changes on the new
feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
