[
https://issues.apache.org/jira/browse/HBASE-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098467#comment-17098467
]
Duo Zhang edited comment on HBASE-19577 at 5/3/20, 3:12 PM:
------------------------------------------------------------
OK, the first problem is in hbase-client, TestFailedServersLog, where we assume
that the log output is log4j. This is easy to fix, just switch to log4j2. And
it is in test code so I think it is fine. Although testing directly on slf4j
will be better.
Another problem is much difficult to fix, as in hbase-http, we have a
HttpRequestLog implementation, where we pass log4j loggers everywhere, and the
code for log4j2 is incompatible with log4j, so there is no straight forward way
to fix it. And I doubt whether it is a good idea to introduce log4j
dependencies directly from a library which maybe used by downstream users, as
it forces the down stream users to also use log4j... Need learn more about this.
was (Author: apache9):
OK, the first problem is in hbase-client, TestFailedServersLog, where we assume
that the log output is log4j. This is easy to fix, just switch to log4j2.
Another problem is much difficult to fix, as in hbase-http, we have a
HttpRequestLog implementation, where we pass log4j loggers everywhere, and the
code for log4j2 is incompatible with log4j, so there is no straight forward way
to fix it. And I doubt whether it is a good idea to introduce log4j
dependencies directly from a library which maybe used by downstream users, as
it forces the down stream users to also use log4j... Need learn more about this.
> Move off log4j1 as our logging backend.
> ---------------------------------------
>
> Key: HBASE-19577
> URL: https://issues.apache.org/jira/browse/HBASE-19577
> Project: HBase
> Issue Type: Sub-task
> Components: logging
> Reporter: Michael Stack
> Assignee: Duo Zhang
> Priority: Major
>
> See HBASE-10092 for discussion. We have inserted slf4j as our frontend. Need
> to swap out the 5-year-old log4j1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
